This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Update ngTranscludeMod.js to be angular 1.5 compatible #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular 1.5 introduces Multi Slot transclusion, which this version hid. This makes it compatible. 'parent' or 'child' may not be used as slot names, and to combine 'parent' with a slot name use the ng-transclude-slot attribute angular/angular.js@a4ada8b#comments https://docs.angularjs.org/api/ng/directive/ngTransclude#multi-slot-transclusion https://docs.angularjs.org/api/ng/service/$compile#transclusion
|
Thanks for this @NickBolles! It'll take me a while to find the time to have a look and test this. Please watch this space. |
|
@Izhaki had a chance to check this out? Seems pretty solid to me, let me know when you have the chance! |
|
Any updates? |
|
@CyborgMaster You can use my branch for now located here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular 1.5 introduces Multi Slot transclusion, which this version hid. This makes it compatible.
'parent' or 'child' may not be used as slot names, and to combine 'parent' with a slot name use the ng-transclude-slot attribute
angular/angular.js@a4ada8b#comments
https://docs.angularjs.org/api/ng/directive/ngTransclude#multi-slot-transclusion
https://docs.angularjs.org/api/ng/service/$compile#transclusion
Its a little messy and overwhelming but here's a plunker
http://plnkr.co/edit/5XGBEX0muH9CSijMfWsH?p=preview